D6268: HiDPI Support for Okular

[Lukas Hetzenecker]

hetzenecker added a comment.


  Thanke for your feedback.
  
  In https://phabricator.kde.org/D6268#121135, @aacid wrote:
  
  > I would very much prefer if you didn't break the ABI of the files in core/
  >
  > Also not sure why you need to pass the devicepixel ratio up and down, isn't it the same basically in all the app?
  
  
  Yes and no. While it would be possible to use `qApp->devicePixelRatio()` (as I've done in `mobile/components`), this would return the highest pixel ratio in the system, in case there are more physical screens with different Scale Factors connected. 
  So, as alternative `QScreen::devicePixelRatio` could be used to return the DPR of the screen the application is shown. I'm not sure yet if this is possible without changing the ABI, but I'll try to.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D6268

To: hetzenecker, davidedmundson, aacid
Cc: sander, anthonyfieroni, #okular, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170703/842753b8/attachment.html>