Review Request 129557: [okular] Enable searching for a phrase split by a newline character in a PDF

[Marduk Bolanos]

> On Jan. 5, 2017, 9:38 a.m., Anthony Fieroni wrote:
> > okular/core/textpage.cpp, line 57
> > <https://git.reviewboard.kde.org/r/129557/diff/2/?file=488706#file488706line57>
> >
> >     Do this
> >     from == QStringLiter("\n") && to == QStringLiteral(" ")

It is not that simple. See my comment above. The comparison function receives `e\n` and `e` followed by space. But now I am using QStringLiteral as per your suggestion.


- Marduk


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129557/#review101816
-----------------------------------------------------------


On Jan. 5, 2017, 10:20 a.m., Marduk Bolanos wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129557/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2017, 10:20 a.m.)
> 
> 
> Review request for Okular and Oliver Sander.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> A blank space in the query is matched against a newline character in the PDF.
> 
> 
> Diffs
> -----
> 
>   okular/core/textpage.cpp 44dfa14 
> 
> Diff: https://git.reviewboard.kde.org/r/129557/diff/
> 
> 
> Testing
> -------
> 
> Tried a few PDF files. It works.
> 
> 
> Thanks,
> 
> Marduk Bolanos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170105/0a467d47/attachment.html>