Review Request 129557: [okular] Enable searching for a phrase split by a newline character in a PDF

Anthony Fieroni bvbfan at abv.bg
Thu Jan 5 09:38:58 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129557/#review101816
-----------------------------------------------------------




okular/core/textpage.cpp (line 57)
<https://git.reviewboard.kde.org/r/129557/#comment68134>

    Do this
    from == QStringLiter("\n") && to == QStringLiteral(" ")


- Anthony Fieroni


On Jan. 5, 2017, 11:30 a.m., Marduk Bolanos wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129557/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2017, 11:30 a.m.)
> 
> 
> Review request for Okular and Oliver Sander.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> A blank space in the query is matched against a newline character in the PDF.
> 
> 
> Diffs
> -----
> 
>   okular/core/textpage.cpp 44dfa14 
> 
> Diff: https://git.reviewboard.kde.org/r/129557/diff/
> 
> 
> Testing
> -------
> 
> Tried a few PDF files. It works.
> 
> 
> Thanks,
> 
> Marduk Bolanos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170105/49fffc5e/attachment.html>


More information about the Okular-devel mailing list