Review Request 129956: Allow to disable automatic search while typing (Fixes bug #326522)

[Marco Scarpetta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129956/
-----------------------------------------------------------

(Updated Feb. 20, 2017, 8:50 a.m.)


Review request for Okular.


Changes
-------

If Okular::Settings::searchAutomatic() is false, the slot FindBar::automaticSearchChanged is not called when we set the saved value on line 86.


Bugs: 326522
    http://bugs.kde.org/show_bug.cgi?id=326522


Repository: okular


Description
-------

Implement an option to disable the automatic search while typing in okular findbar. When the "automatic search" option is disabled the user must press the return key to start searching.


Diffs (updated)
-----

  conf/okular.kcfg e06dd91b 
  ui/findbar.h 2c34d0de 
  ui/findbar.cpp 09201e78 
  ui/searchlineedit.h b8230e65 
  ui/searchlineedit.cpp baac8be0 

Diff: https://git.reviewboard.kde.org/r/129956/diff/


Testing
-------

I ran okular and tested that both searching modes work.


Thanks,

Marco Scarpetta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170220/7da54821/attachment.html>