Review Request 129956: Allow to disable automatic search while typing (Fixes bug #326522)

[Marco Scarpetta]

> On Feb. 19, 2017, 11:25 p.m., Albert Astals Cid wrote:
> > Is it on purpose that all the other search fields in the left bar are still automatic search?

Yes, according to comments to the bug report, the problem using automatic search is that the document can jump to another page during search. The search fields on the left don't cause that problem.


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129956/#review102561
-----------------------------------------------------------


On Feb. 17, 2017, 12:17 p.m., Marco Scarpetta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129956/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2017, 12:17 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 326522
>     http://bugs.kde.org/show_bug.cgi?id=326522
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Implement an option to disable the automatic search while typing in okular findbar. When the "automatic search" option is disabled the user must press the return key to start searching.
> 
> 
> Diffs
> -----
> 
>   conf/okular.kcfg e06dd91b 
>   ui/findbar.h 2c34d0de 
>   ui/findbar.cpp 09201e78 
>   ui/searchlineedit.h b8230e65 
>   ui/searchlineedit.cpp baac8be0 
> 
> Diff: https://git.reviewboard.kde.org/r/129956/diff/
> 
> 
> Testing
> -------
> 
> I ran okular and tested that both searching modes work.
> 
> 
> Thanks,
> 
> Marco Scarpetta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170220/47039391/attachment.html>