refactoring in pageview class

[Albert Astals Cid]

El dimecres, 15 de febrer de 2017, a les 11:23:58 CET, Oliver Sander va 
escriure:
> > Personally I'm not very happy about refactorings, usually they just end up
> > either: * Causing regressions because there's a corner case the
> > refactoring didn't think of * Being as complex as the original code,
> > because original code is complex for a reason.
> I see your point.  On the other hand, sometimes cleanup does have value,
> because it makes it easier for newcomers (like me) to understand the code.
> > Also *personally* I think time would be better spent fixing some actual
> > bugs instead of just making the code nicer to look at, but it is your
> > time, so you spend it as you think it's better/more fun for you :)
> 
> Compromise suggestion: habruening, as your are just starting out, maybe
> refactoring the entire pageview class is too much to tackle at once.  How
> about starting with something smaller?  Like fixing a simple bug from the
> bug tracker?  Or doing a small, specific bit of cleanup?  Or write a unit
> test for some particular feature?  Actually, cleanup patches are generally
> better liked when they are accompagnied by unit tests. Albert, anything
> specific that you can suggest here to get him started?

If he wants to refactor stuff, let him refactor stuff, as I said I don't 
consider myself the maintainer anymore, so if someone reviews and commits his 
code, good.

If you want me to review the code, i'll really prefer a small chunk of code/
refactor with an explanation of why it is better and ideally what bug it 
fixes.

Cheers,
  Albert

> 
> Cheers,
> Oliver