Review Request 129909: Fix reading comicbooks in zip format

Eugene Shalygin eugene.shalygin at gmail.com
Mon Feb 6 17:23:52 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129909/
-----------------------------------------------------------

(Updated Лют. 6, 2017, 6:23 після полудня)


Status
------

This change has been discarded.


Review request for Okular and Albert Astals Cid.


Repository: okular


Description
-------

Okular refuses to load .cbr files because a `QIODevice` object returned by `KArchiveFile::createDevice()` reports its size to be 0 and because of that `QImageReader` refuses to read. Proposed solution: if that device's `QIODevice::size()` returns 0, copy its content into a temporary file and load image from the file.


Diffs
-----

  generators/comicbook/document.cpp 34c4cb5a 

Diff: https://git.reviewboard.kde.org/r/129909/diff/


Testing
-------

Well, it loads .cbr files now :)


Thanks,

Eugene Shalygin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170206/5eab14fa/attachment.html>


More information about the Okular-devel mailing list