Review Request 129909: Fix reading comicbooks in zip format

[Albert Astals Cid]

> On Feb. 2, 2017, 8:33 p.m., Albert Astals Cid wrote:
> > It's a bug in KArchive or a bug in Qt.
> > https://mail.kde.org/pipermail/kde-frameworks-devel/2017-February/042506.html
> 
> Eugene Shalygin wrote:
>     Thanks!

Please discard this, https://cgit.kde.org/karchive.git/commit/?id=14653ce06ab31eaaa7a9eef75a257e17a048f9ba is the proper fix.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129909/#review102349
-----------------------------------------------------------


On Feb. 1, 2017, 3:44 p.m., Eugene Shalygin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129909/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2017, 3:44 p.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Okular refuses to load .cbr files because a `QIODevice` object returned by `KArchiveFile::createDevice()` reports its size to be 0 and because of that `QImageReader` refuses to read. Proposed solution: if that device's `QIODevice::size()` returns 0, copy its content into a temporary file and load image from the file.
> 
> 
> Diffs
> -----
> 
>   generators/comicbook/document.cpp 34c4cb5a 
> 
> Diff: https://git.reviewboard.kde.org/r/129909/diff/
> 
> 
> Testing
> -------
> 
> Well, it loads .cbr files now :)
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170204/8ca40afb/attachment.html>