D7495: Do not start reloading again if we're reloading

[Henrik Fehlauer]

rkflx added a comment.


  Yay for reviews finding problems before users do \o/
  
  > majorly unchanged for years, and if someone breaks it, well it'll break and we'll fix it.
  
  If we can choose between a good and an improved solution, I'd say we should always pick the latter. Maybe I should have added a comment only instead of implementing it myself, but I wanted to check how it would work out and spare you some work. You have seen 384142 <https://bugs.kde.org/show_bug.cgi?id=384142> coming in only yesterday, please don't risk more crashes unnecessarily.
  
  > `SetBoolToFalseOnScopeExit` [...] should be less than 10 lines of code.
  
  That's both harder to understand and longer than the additional 0 lines of code for the RAII-mutex solution, as well as less compact in terms of the number of separate code fragments.
  
  I'm all for fixing the original issue, but let's do it properly.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D7495

To: aacid
Cc: rkflx, #okular, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170830/0d517f19/attachment-0001.html>