D7495: Do not start reloading again if we're reloading
Henrik Fehlauer
noreply at phabricator.kde.org
Mon Aug 28 23:35:48 UTC 2017
rkflx added a comment.
Good catch, I stumbled upon this bug before. This even prevents segfaults on exit.
However, I think there's a potentially costly maintainability risk: When someone wants to change some code in slotDoFileDirty(), it's quite easy to forget resetting your new bool, causing all kinds of weird bugs down the line.
I thought about an alternative implementation using RAII without this problem and expanded the description a little bit. Please see https://phabricator.kde.org/D7595.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D7495
To: aacid
Cc: rkflx, #okular, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170828/c585ecaf/attachment.html>
More information about the Okular-devel
mailing list