Review Request 130214: Simplify the drawing of buffered highlight rectangles

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130214/#review103575
-----------------------------------------------------------


Fix it, then Ship it!





ui/pagepainter.cpp (line 396)
<https://git.reviewboard.kde.org/r/130214/#comment68934>

    space after ,



ui/pagepainter.cpp 
<https://git.reviewboard.kde.org/r/130214/#comment68933>

    Remove the has_alpha variable?


- Albert Astals Cid


On Aug. 3, 2017, 11:32 a.m., Oliver Sander wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130214/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2017, 11:32 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Previously, they were drawn by modifying individual pixels    of the QImage.  With this patch we simply use a QPainter. That makes the code a lot shorter.
> 
> This follows a suggestion from https://blog.hetzenecker.me/2017-06-30-gsoc-kdegraphics-okular/
> 
> The code that is removed by this patch is the sole consumer of the has_alpha variable.  Consequently the compiler now warns about an unused variable.  Should I send another patch removing that variable?
> 
> 
> Diffs
> -----
> 
>   ui/pagepainter.cpp ecfafa502 
> 
> Diff: https://git.reviewboard.kde.org/r/130214/diff/
> 
> 
> Testing
> -------
> 
> Tested with pdf and odt documents, and different text colors, and I could not find any functional difference.  In particular, testing with pdf and odt makes sure that both branches of the if(has_alpha) conditional are tested.
> 
> 
> Thanks,
> 
> Oliver Sander
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170807/cde8bfb3/attachment-0001.html>