Review Request 130214: Simplify the drawing of buffered highlight rectangles

[Oliver Sander]

> On Aug. 3, 2017, 8:39 p.m., Albert Astals Cid wrote:
> > Is this part of his branches? Maybe makes more sense for him to create the MR and not you?

The blog only suggests this as a possible modernization, but claims that it is beyond the gsoc project's scope to actually do it.

But now that you ask I went out to look at the gsoc2017_hidpi_support branch.  Lukas did clean up that section a little bit, but not as thoroughly as my patch does.


- Oliver


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130214/#review103544
-----------------------------------------------------------


On Aug. 3, 2017, 11:32 a.m., Oliver Sander wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130214/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2017, 11:32 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Previously, they were drawn by modifying individual pixels    of the QImage.  With this patch we simply use a QPainter. That makes the code a lot shorter.
> 
> This follows a suggestion from https://blog.hetzenecker.me/2017-06-30-gsoc-kdegraphics-okular/
> 
> The code that is removed by this patch is the sole consumer of the has_alpha variable.  Consequently the compiler now warns about an unused variable.  Should I send another patch removing that variable?
> 
> 
> Diffs
> -----
> 
>   ui/pagepainter.cpp ecfafa502 
> 
> Diff: https://git.reviewboard.kde.org/r/130214/diff/
> 
> 
> Testing
> -------
> 
> Tested with pdf and odt documents, and different text colors, and I could not find any functional difference.  In particular, testing with pdf and odt makes sure that both branches of the if(has_alpha) conditional are tested.
> 
> 
> Thanks,
> 
> Oliver Sander
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170804/ffe6f487/attachment.html>