Review Request 130087: Fix segfault when document is reloaded / closed while annotation is selected

Tobias Deiminger haxtibal at t-online.de
Thu Apr 13 17:18:49 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130087/
-----------------------------------------------------------

(Updated April 13, 2017, 5:18 p.m.)


Status
------

This change has been marked as submitted.


Review request for Okular.


Changes
-------

Submitted with commit 69dca1e7dd885f9a34c957994eafa7b69a752728 by Albert Astals Cid on behalf of Tobias Deiminger to branch Applications/17.04.


Bugs: 378696
    http://bugs.kde.org/show_bug.cgi?id=378696


Repository: okular


Description
-------

Prevent MouseAnnotation from accessing PageViewItem widgets any longer after PageView deletes them in PageView::notifySetup().


Diffs
-----

  ui/pageview.cpp 88ffe62418f3b68ca8c2314c54f13226d2ed6191 
  ui/pageviewmouseannotation.h 6a131d01c24f99768593d959eb3114b2f5519049 
  ui/pageviewmouseannotation.cpp dbd483a5de5fd46f53f8177ed7997e66950c5bf6 

Diff: https://git.reviewboard.kde.org/r/130087/diff/


Testing
-------

Works for [Oliver](https://bugs.kde.org/show_bug.cgi?id=378696#c4) ;)


Thanks,

Tobias Deiminger

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170413/326e8fb7/attachment.html>


More information about the Okular-devel mailing list