Review Request 130087: Fix segfault when document is reloaded / closed while annotation is selected

Albert Astals Cid aacid at kde.org
Thu Apr 13 17:18:41 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130087/#review103041
-----------------------------------------------------------


Ship it!




Ship It!

- Albert Astals Cid


On abr. 13, 2017, 8:41 a.m., Tobias Deiminger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130087/
> -----------------------------------------------------------
> 
> (Updated abr. 13, 2017, 8:41 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 378696
>     http://bugs.kde.org/show_bug.cgi?id=378696
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Prevent MouseAnnotation from accessing PageViewItem widgets any longer after PageView deletes them in PageView::notifySetup().
> 
> 
> Diffs
> -----
> 
>   ui/pageview.cpp 88ffe62418f3b68ca8c2314c54f13226d2ed6191 
>   ui/pageviewmouseannotation.h 6a131d01c24f99768593d959eb3114b2f5519049 
>   ui/pageviewmouseannotation.cpp dbd483a5de5fd46f53f8177ed7997e66950c5bf6 
> 
> Diff: https://git.reviewboard.kde.org/r/130087/diff/
> 
> 
> Testing
> -------
> 
> Works for [Oliver](https://bugs.kde.org/show_bug.cgi?id=378696#c4) ;)
> 
> 
> Thanks,
> 
> Tobias Deiminger
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20170413/b75e9677/attachment.html>


More information about the Okular-devel mailing list