Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen
Martin Tobias Holmedahl Sandsmark
martin.sandsmark at kde.org
Sun Sep 4 15:35:52 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128821/#review98876
-----------------------------------------------------------
Ship it!
just some nitpicks, but nothing I think should block, but feel free to fix them before pushing. :-)
ui/pageview.h (line 134)
<https://git.reviewboard.kde.org/r/128821/#comment66575>
nitpick; inconsistent spacing
- Martin Tobias Holmedahl Sandsmark
On Sept. 4, 2016, 3:16 p.m., Oliver Sander wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128821/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2016, 3:16 p.m.)
>
>
> Review request for Okular.
>
>
> Bugs: 366781
> http://bugs.kde.org/show_bug.cgi?id=366781
>
>
> Repository: okular
>
>
> Description
> -------
>
> The attached patch implements document zoom controlled by a two-finger pinch gesture on a touch screen.
>
> The actual zooming was done by copy'n'paste, I don't understand the full details of how zooming works in okular, yet. So a bit of review would be appreciated.
>
>
> Diffs
> -----
>
> ui/pageview.h 01c39bf
> ui/pageview.cpp cd53407
>
> Diff: https://git.reviewboard.kde.org/r/128821/diff/
>
>
> Testing
> -------
>
> I tested it on my Lenovo Thinkpad Yoga, and it works nicely there.
>
>
> Thanks,
>
> Oliver Sander
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160904/494ed406/attachment.html>
More information about the Okular-devel
mailing list