Review Request 128821: [frameworks] Implement zooming with a pinch gesture on a touch screen
Oliver Sander
oliver.sander at tu-dresden.de
Sun Sep 4 15:16:32 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128821/
-----------------------------------------------------------
(Updated Sept. 4, 2016, 3:16 p.m.)
Review request for Okular.
Changes
-------
Implemented (most of) Martin's suggestions
Bugs: 366781
http://bugs.kde.org/show_bug.cgi?id=366781
Repository: okular
Description
-------
The attached patch implements document zoom controlled by a two-finger pinch gesture on a touch screen.
The actual zooming was done by copy'n'paste, I don't understand the full details of how zooming works in okular, yet. So a bit of review would be appreciated.
Diffs (updated)
-----
ui/pageview.h 01c39bf
ui/pageview.cpp cd53407
Diff: https://git.reviewboard.kde.org/r/128821/diff/
Testing
-------
I tested it on my Lenovo Thinkpad Yoga, and it works nicely there.
Thanks,
Oliver Sander
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160904/55c06e3c/attachment.html>
More information about the Okular-devel
mailing list