[Okular-devel] Review Request 128507: Port: Open relative path again

[Olivier Churlaud]

> On July 24, 2016, 4:18 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> > core/document.cpp, line 4025
> > <https://git.reviewboard.kde.org/r/128507/diff/2/?file=472240#file472240line4025>
> >
> >     why create a new QUrl?

It was like this in master.


> On July 24, 2016, 4:18 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> > core/document.cpp, line 4018
> > <https://git.reviewboard.kde.org/r/128507/diff/2/?file=472240#file472240line4018>
> >
> >     instead use something like:
> >         if (url.scheme() == "http" && url.host().isEmpty() && url.fileName().endsWith(".pdf"))
> >     
> >     is a bit easier to read, and handles corner cases better (with fragments and paths etc).
> >     
> >     can probably drop the scheme() check as well?

i'm not sure the scheme works: we want to fit http:text and not http://text and I think that scheme only works with XXX://


> On July 24, 2016, 4:18 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> > core/document.cpp, line 4032
> > <https://git.reviewboard.kde.org/r/128507/diff/2/?file=472240#file472240line4032>
> >
> >     maybe a better comment would be "KRun autodeletes"?

I let the text that was in master I must say :) But yes I can write this.


- Olivier


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128507/#review97800
-----------------------------------------------------------


On July 23, 2016, 1:24 p.m., Olivier Churlaud wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128507/
> -----------------------------------------------------------
> 
> (Updated July 23, 2016, 1:24 p.m.)
> 
> 
> Review request for Okular, Albert Astals Cid and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> This brings back the opening of files with relative path.
> 
> However it was written "correct this mess", and I just did a port of what was there. Do I push it anyway?
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d999cbe 
>   core/document.cpp 2f99a8c 
> 
> Diff: https://git.reviewboard.kde.org/r/128507/diff/
> 
> 
> Testing
> -------
> 
> Compiled and Tested
> 
> 
> Thanks,
> 
> Olivier Churlaud
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160724/3cab427c/attachment.html>