[Okular-devel] Review Request 128507: Port: Open relative path again
Martin Tobias Holmedahl Sandsmark
martin.sandsmark at kde.org
Sun Jul 24 14:18:14 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128507/#review97800
-----------------------------------------------------------
core/document.cpp (line 4018)
<https://git.reviewboard.kde.org/r/128507/#comment65906>
instead use something like:
if (url.scheme() == "http" && url.host().isEmpty() && url.fileName().endsWith(".pdf"))
is a bit easier to read, and handles corner cases better (with fragments and paths etc).
can probably drop the scheme() check as well?
core/document.cpp (line 4025)
<https://git.reviewboard.kde.org/r/128507/#comment65907>
why create a new QUrl?
core/document.cpp (line 4032)
<https://git.reviewboard.kde.org/r/128507/#comment65908>
maybe a better comment would be "KRun autodeletes"?
- Martin Tobias Holmedahl Sandsmark
On July 23, 2016, 11:24 a.m., Olivier Churlaud wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128507/
> -----------------------------------------------------------
>
> (Updated July 23, 2016, 11:24 a.m.)
>
>
> Review request for Okular, Albert Astals Cid and Martin Tobias Holmedahl Sandsmark.
>
>
> Repository: okular
>
>
> Description
> -------
>
> This brings back the opening of files with relative path.
>
> However it was written "correct this mess", and I just did a port of what was there. Do I push it anyway?
>
>
> Diffs
> -----
>
> CMakeLists.txt d999cbe
> core/document.cpp 2f99a8c
>
> Diff: https://git.reviewboard.kde.org/r/128507/diff/
>
>
> Testing
> -------
>
> Compiled and Tested
>
>
> Thanks,
>
> Olivier Churlaud
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160724/c82772b0/attachment.html>
More information about the Okular-devel
mailing list