[Okular-devel] Review Request 128435: Make the open dialog a bit more usable without the Plasma QPA

[Martin Tobias Holmedahl Sandsmark]

> On July 13, 2016, 10:04 p.m., Aleix Pol Gonzalez wrote:
> > shell/shell.cpp, line 441
> > <https://git.reviewboard.kde.org/r/128435/diff/1/?file=471627#file471627line441>
> >
> >     I think it would make sense to move that logic upstream.
> >     
> >     It's not something specific about okular.
> 
> Martin Tobias Holmedahl Sandsmark wrote:
>     move which logic to which upstream? QFileDialog?
> 
> Aleix Pol Gonzalez wrote:
>     Whichever QPT that is underwhelming you and pushed you to make this RR. Or QFileDialog, if it's general.
> 
> Martin Tobias Holmedahl Sandsmark wrote:
>     Ah, it is the default implementation in QFileDialog itself.
> 
> Martin Tobias Holmedahl Sandsmark wrote:
>     FWIW, I have a couple of implementations of it for upstream, but I don't it makes a lot of sense as it changes behaviour a lot.
>     
>     http://ix.io/15nr is the least invasive imho.
> 
> Aleix Pol Gonzalez wrote:
>     I don't see the review in Qt's gerrit. Do you have it at hand?

I don't think it is a good solution, it only fixes it for setMimeTypeFilters().

When I wrote I have a couple of implementations I meant code I had implemented to test, but none of them are good because they change behavior and break unit tests so I haven't submitted it.


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128435/#review97361
-----------------------------------------------------------


On July 17, 2016, 6:09 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128435/
> -----------------------------------------------------------
> 
> (Updated July 17, 2016, 6:09 p.m.)
> 
> 
> Review request for Okular, Albert Astals Cid and Aleix Pol Gonzalez.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Without the Plasma QPA now the file open dialog just lets you select a single random filetype to view at the time. This tries to improve that, but I'm not sure if that's something you/we want?
> 
> 
> Diffs
> -----
> 
>   shell/shell.cpp bca7206 
> 
> Diff: https://git.reviewboard.kde.org/r/128435/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160721/7ece806f/attachment.html>