[Okular-devel] Review Request 128435: Make the open dialog a bit more usable without the Plasma QPA

Martin Tobias Holmedahl Sandsmark martin.sandsmark at kde.org
Sun Jul 17 18:09:17 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128435/
-----------------------------------------------------------

(Updated July 17, 2016, 6:09 p.m.)


Review request for Okular, Albert Astals Cid and Aleix Pol Gonzalez.


Changes
-------

use foreach for consistency and ensuring we don't accidentally detach the container (we can't use qAsConst(), that's too new).


Repository: okular


Description
-------

Without the Plasma QPA now the file open dialog just lets you select a single random filetype to view at the time. This tries to improve that, but I'm not sure if that's something you/we want?


Diffs (updated)
-----

  shell/shell.cpp bca7206 

Diff: https://git.reviewboard.kde.org/r/128435/diff/


Testing
-------


Thanks,

Martin Tobias Holmedahl Sandsmark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160717/38a84c7e/attachment.html>


More information about the Okular-devel mailing list