[Okular-devel] Review Request 127042: Fix QUrl string encoding

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127042/#review92804
-----------------------------------------------------------


Ship it!




Looks good to me.

- Albert Vaca Cintora


On feb. 24, 2016, 9:21 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127042/
> -----------------------------------------------------------
> 
> (Updated feb. 24, 2016, 9:21 a.m.)
> 
> 
> Review request for Okular and Alex Richardson.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> This Url is converted in to a string to be parsed back using `QUrl( urlString, QUrl::StrictMode )`.
> By default, it uses `PrettyDecoded`, which makes `QUrl::StrictMode` choke.
> 
> An alternative patch would be to overload openDocument to also take QUrl and skip the back-and-forth conversion.
> 
> 
> Diffs
> -----
> 
>   shell/okular_main.cpp 9bdc1fe 
>   shell/shell.h c7c155b 
>   shell/shell.cpp c97054a 
> 
> Diff: https://git.reviewboard.kde.org/r/127042/diff/
> 
> 
> Testing
> -------
> 
> Now I can open files with a space in it.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160226/fefad5c7/attachment.html>