[Okular-devel] Review Request 127042: Fix QUrl string encoding

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127042/
-----------------------------------------------------------

(Updated Feb. 24, 2016, 6:21 p.m.)


Review request for Okular and Alex Richardson.


Changes
-------

* Drops the strict parsing.
* Overloads openDocument so we don't need to go QUrl -> QString -> QUrl.


Repository: okular


Description
-------

This Url is converted in to a string to be parsed back using `QUrl( urlString, QUrl::StrictMode )`.
By default, it uses `PrettyDecoded`, which makes `QUrl::StrictMode` choke.

An alternative patch would be to overload openDocument to also take QUrl and skip the back-and-forth conversion.


Diffs (updated)
-----

  shell/okular_main.cpp 9bdc1fe 
  shell/shell.h c7c155b 
  shell/shell.cpp c97054a 

Diff: https://git.reviewboard.kde.org/r/127042/diff/


Testing
-------

Now I can open files with a space in it.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160224/b7e4b3a5/attachment.html>