[Okular-devel] Review Request 127013: Properly show marker for current section in TOC

[Albert Astals Cid]

> On Feb. 11, 2016, 10:27 p.m., Miklós Máté wrote:
> > ui/toc.cpp, line 44
> > <https://git.reviewboard.kde.org/r/127013/diff/1/?file=443811#file443811line44>
> >
> >     The model has to know about the treeview, see line 209. This also makes sure that the model is deleted when the view is deleted, just like when this is used as a KPart (see finishReload).

> This also makes sure that the model is deleted when the view is deleted

But that already happens becase the view is the parent of the model, no?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127013/#review92277
-----------------------------------------------------------


On Feb. 8, 2016, 5:49 p.m., Miklós Máté wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127013/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2016, 5:49 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> fixes bug #342076
> 
> 
> Diffs
> -----
> 
>   ui/toc.cpp 09625af 
>   ui/tocmodel.cpp ce93366 
> 
> Diff: https://git.reviewboard.kde.org/r/127013/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Miklós Máté
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160216/5782c503/attachment.html>