[Okular-devel] Review Request 127013: Properly show marker for current section in TOC

Miklós Máté mtmkls at freemail.hu
Thu Feb 11 22:27:44 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127013/#review92277
-----------------------------------------------------------




ui/toc.cpp (line 44)
<https://git.reviewboard.kde.org/r/127013/#comment62943>

    The model has to know about the treeview, see line 209. This also makes sure that the model is deleted when the view is deleted, just like when this is used as a KPart (see finishReload).



ui/tocmodel.cpp (line 152)
<https://git.reviewboard.kde.org/r/127013/#comment62944>

    Instead of marking the toc items that point to the current page I mark the toc items that *contain* the current page.


- Miklós Máté


On Feb. 8, 2016, 5:49 p.m., Miklós Máté wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127013/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2016, 5:49 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> fixes bug #342076
> 
> 
> Diffs
> -----
> 
>   ui/toc.cpp 09625af 
>   ui/tocmodel.cpp ce93366 
> 
> Diff: https://git.reviewboard.kde.org/r/127013/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Miklós Máté
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160211/901d4162/attachment.html>


More information about the Okular-devel mailing list