[Okular-devel] Review Request 125020: okular: Add zip/x-rar mimetype to .desktop files

[Albert Astals Cid]

> On Sept. 16, 2015, 8:59 p.m., Albert Astals Cid wrote:
> > Actually, if you just leave the libokularGenerator_comicbook.desktop change this should be ok, tells okular this plugin may know how to open rar files, so if you use the file dialog or the command line it should work, but it doesn't tell the rest of the world so dolphin et al won't suggest okular to open random .rar files.  I think this should be a good enough compromise, can you check what i am saying is actually true?
> 
> Boris Egorov wrote:
>     I'll check it asap.
> 
> Boris Egorov wrote:
>     Completely forgot about this bug.
>     So, each of the files affect different behavior.
>     
>         libokularGenerator_comicbook.desktop allows to open files from command line
>         okularComicbook.desktop allows to select them in Okular's file dialog
>         okularApplication_comicbook.desktop shows Okular in Dolphin context menu for .zip and .rar files
>         
>     So, I guess we can leave changes in the first two files, but rejects the last one. What do you think?

Those files don't do what you say they do, as i said on my original one libokularGenerator_comicbook.desktop should be more than enough, have you tried just leaving the change there?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125020/#review85517
-----------------------------------------------------------


On Sept. 1, 2015, 4:02 p.m., Boris Egorov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125020/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2015, 4:02 p.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 343645
>     http://bugs.kde.org/show_bug.cgi?id=343645
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Adds ability to open rar/zip archives with images in okular
> 
> 
> Diffs
> -----
> 
>   generators/comicbook/libokularGenerator_comicbook.desktop 5a91a5f 
>   generators/comicbook/okularApplication_comicbook.desktop dee494b 
>   generators/comicbook/okularComicbook.desktop 1dded78 
> 
> Diff: https://git.reviewboard.kde.org/r/125020/diff/
> 
> 
> Testing
> -------
> 
> Build; open some archives in okular.
> 
> 
> Thanks,
> 
> Boris Egorov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160216/3215cd92/attachment-0001.html>