[Okular-devel] Review Request 126842: Port to FindPoppler from extra-cmake-modules.
Christophe Giboudeaux
cgiboudeaux at gmx.com
Thu Feb 11 21:35:05 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126842/#review92274
-----------------------------------------------------------
generators/CMakeLists.txt (lines 12 - 13)
<https://git.reviewboard.kde.org/r/126842/#comment62942>
Not needed. FindPoppler already sets this
- Christophe Giboudeaux
On Jan. 22, 2016, 12:31 p.m., Michael Palimaka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126842/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 12:31 p.m.)
>
>
> Review request for Okular.
>
>
> Repository: okular
>
>
> Description
> -------
>
> Some small changes are required to ensure build passes with ECM's new FindPoppler.cmake.
>
>
> Diffs
> -----
>
> CMakeLists.txt 492de006c58904f0da94f4cfb9e2ca79ab839c45
> cmake/modules/FindPoppler.cmake 80a78627438703a9db4d7cd97649098c41b1b2ce
> generators/CMakeLists.txt ce1d9bfeeb401466c47648d1d828fbd2ff4b18f6
> generators/poppler/CMakeLists.txt 740b6fd8d6311bee80845a034bba148d443afbd4
>
> Diff: https://git.reviewboard.kde.org/r/126842/diff/
>
>
> Testing
> -------
>
> Builds, PDFs still open.
>
>
> Thanks,
>
> Michael Palimaka
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160211/0d7e6114/attachment.html>
More information about the Okular-devel
mailing list