[Okular-devel] Review Request 127036: Fix for CUPS printing in Okular 1.0.0

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127036/#review92421
-----------------------------------------------------------


Ship it!




Ship It!

- Albert Astals Cid


On Feb. 11, 2016, 1:04 a.m., Krzysztof Pyrkosz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127036/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2016, 1:04 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Okular is checking for Q_WS_X11 definition (which is not available since Qt 5) to detect CUPS, so detection always fails making CUPS parameters ignored. I have changed it to:
>     #if defined(Q_OS_UNIX) && !defined(Q_OS_OSX)
> 
> 
> Diffs
> -----
> 
>   core/fileprinter.cpp 2c8b199 
> 
> Diff: https://git.reviewboard.kde.org/r/127036/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Krzysztof Pyrkosz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160216/ea60e653/attachment.html>