[Okular-devel] Review Request 127036: Fix for CUPS printing in Okular 1.0.0

Krzysztof Pyrkosz pyrkosz at o2.pl
Thu Feb 11 01:04:04 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127036/
-----------------------------------------------------------

Review request for Okular.


Repository: okular


Description
-------

Okular is checking for Q_WS_X11 definition (which is not available since Qt 5) to detect CUPS, so detection always fails making CUPS parameters ignored. I have changed it to:
    #if defined(Q_OS_UNIX) && !defined(Q_OS_OSX)


Diffs
-----

  core/fileprinter.cpp 2c8b199 

Diff: https://git.reviewboard.kde.org/r/127036/diff/


Testing
-------


Thanks,

Krzysztof Pyrkosz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20160211/f7fa0b45/attachment.html>


More information about the Okular-devel mailing list