[Okular-devel] Review Request 124961: Interact with hyperlinks in TextSelect mode (supercedes 124723)

[Jake Linder]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124961/
-----------------------------------------------------------

(Updated Sept. 15, 2015, 5:41 a.m.)


Review request for Okular and Albert Astals Cid.


Changes
-------

typos


Bugs: 318078
    http://bugs.kde.org/show_bug.cgi?id=318078


Repository: okular


Description
-------

Supercedes https://git.reviewboard.kde.org/r/124723/:

- Rebase to apply cleanly against just-merged 172d78c (Trim Selection Feature)
- Drop the refactoring patch (seperate problem), sticking with the code duplication for now.
- Added seperate patch (post changes) fixing whitespace issue in gargantuan switch statement. Take it or leave it.


Diffs
-----

  ui/pageview.cpp dc9eab8301b05e57bfdd537d47b33da594759573 

Diff: https://git.reviewboard.kde.org/r/124961/diff/


Testing (updated)
-------

- cursor switches to Hand when hovering over link in TextSelect mode.
- clicking on hyperlink jumps to destination in TextSelect mode.
- text selection & copy still works.
- can text-select "over and across" hyperlink.
- can text-select starting at text and ending selection in middle of hyperlink.
- can text-select starting from hyperlink with click and drag.
- can jump to link while there's an active selection of text.
- can jump to link while there's an active selection spanning a hyperlink.
- doesn't crash when switching away from window and back + clicking off page
- when textselect overlaps a link, r-click on the link gives the "follow this link" content menu, r-click off link gives the "Copy Text"/etc' context menu
- text selection works when selecting left to right or right to left (begin/end selection works out no matter in what order user provides them)


Thanks,

Jake  Linder

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150915/c59c0066/attachment.html>