[Okular-devel] Review Request 124961: Interact with hyperlinks in TextSelect mode (supercedes 124723)

[Jake Linder]

> On Sept. 14, 2015, 10:44 p.m., Albert Astals Cid wrote:
> > This is cool, it touches a bit of a critical code so i'm giving it some more review, thanks for the patch :)

That big switch is  difficult to manage, so careful review is welcome.
fwiw, I've been using it without issues since posted.


- Jake


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124961/#review85406
-----------------------------------------------------------


On Aug. 28, 2015, 7:05 a.m., Jake  Linder wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124961/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2015, 7:05 a.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 318078
>     http://bugs.kde.org/show_bug.cgi?id=318078
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Supercedes https://git.reviewboard.kde.org/r/124723/:
> 
> - Rebase to apply cleanly against just-merged 172d78c (Trim Selection Feature)
> - Drop the refactoring patch (seperate problem), sticking with the code duplication for now.
> - Added seperate patch (post changes) fixing whitespace issue in gargantuan switch statement. Take it or leave it.
> 
> 
> Diffs
> -----
> 
>   ui/pageview.cpp dc9eab8301b05e57bfdd537d47b33da594759573 
> 
> Diff: https://git.reviewboard.kde.org/r/124961/diff/
> 
> 
> Testing
> -------
> 
> - cursor switches to to Hand when hovering over link in TextSelect mode.
> - clicking on hyperlink jumps to destination in TextSelect mode.
> - text selection & copy still works.
> - can text-select "over and across" hyperlink.
> - can text-select starting at text and ending selection in middle of hyperlink.
> - can text-select starting from hyperlink with click and drag.
> - can jump to link while there's an active selection.
> - can jump to link while there's an active selection spanning same hyperlink.
> - doesn't crash when switching away from window and back + clicking off page
> - when textselect overlaps a link, r-click on the link gives the "follow this link" content menu, r-click off link gives the "Copy Text"/etc' context menu
> - text selection works whe selecting left to right or right to left (begin/end selection work out no matter in what order user provides them)
> 
> 
> Thanks,
> 
> Jake  Linder
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150915/19e21ce5/attachment-0001.html>