[Okular-devel] Review Request 123085: Use descriptive KGuiItem labels for buttons in calls to KMessageBox

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123085/#review78250
-----------------------------------------------------------



part.cpp (line 1468)
<https://git.reviewboard.kde.org/r/123085/#comment53601>

    why the extra verbosity?



ui/searchlineedit.cpp (line 258)
<https://git.reviewboard.kde.org/r/123085/#comment53602>

    Why is "Continue from beginning" a better answer than "Yes" to the question "Continue from beginning?"


- Albert Astals Cid


On mar. 20, 2015, 5:46 p.m., sahil sehgal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123085/
> -----------------------------------------------------------
> 
> (Updated mar. 20, 2015, 5:46 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 309739
>     http://bugs.kde.org/show_bug.cgi?id=309739
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Earlier the KmessageBox dialog box contained yes, no or continue buttons without any description. But now there is description like "Continue searching" etc in the boxes.
> 
> 
> Diffs
> -----
> 
>   part.cpp 36438af 
>   ui/searchlineedit.cpp 2add7fa 
> 
> Diff: https://git.reviewboard.kde.org/r/123085/diff/
> 
> 
> Testing
> -------
> 
> Executed successfully on the dialog boxes.
> 
> 
> Thanks,
> 
> sahil sehgal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150330/6e147526/attachment.html>