<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123085/">https://git.reviewboard.kde.org/r/123085/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/123085/diff/1/?file=355932#file355932line1468" style="color: black; font-weight: bold; text-decoration: underline;">part.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool Part::openFile()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1468</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="n">KGuiItem</span> <span class="n">yesItem</span> <span class="o">=</span> <span class="n">KGuiItem</span><span class="p">(</span> <span class="n">i18n</span><span class="p">(</span> <span class="s">"Allow"</span> <span class="p">),</span> <span class="s">"dialog-ok"</span><span class="p">,</span> <span class="n">i18n</span><span class="p">(</span> <span class="s">"Allow the presentation mode"</span> <span class="p">)</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1468</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="n">KGuiItem</span> <span class="n">yesItem</span> <span class="o">=</span> <span class="n">KGuiItem</span><span class="p">(</span> <span class="n">i18n</span><span class="p">(</span> <span class="s">"Allow<span class="hl"> Presentation mode</span>"</span> <span class="p">),</span> <span class="s">"dialog-ok"</span><span class="p">,</span> <span class="n">i18n</span><span class="p">(</span> <span class="s">"Allow the presentation mode"</span> <span class="p">)</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">why the extra verbosity?</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/123085/diff/1/?file=355933#file355933line258" style="color: black; font-weight: bold; text-decoration: underline;">ui/searchlineedit.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void SearchLineEdit::searchFinished( int id, Okular::Document::SearchStatus endStatus )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">258</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span> <span class="n">KMessageBox</span><span class="o">::</span><span class="n">questionYesNo</span><span class="p">(</span><span class="n">window</span><span class="p">(),</span> <span class="n">question</span><span class="p">,</span> <span class="n">QString</span><span class="p">(),</span> <span class="n">KStandardGuiItem</span><span class="o">::</span><span class="n">cont</span><span class="p">(),</span> <span class="n">KStandardGuiItem</span><span class="o">::</span><span class="n">cancel</span><span class="p">())</span> <span class="o">==</span> <span class="n">KMessageBox</span><span class="o">::</span><span class="n">Yes</span> <span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">258</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KGuiItem</span> <span class="n">cont</span> <span class="o">=</span> <span class="n">KGuiItem</span><span class="p">(</span> <span class="n">i18n</span><span class="p">(</span> <span class="s">"Continue from begining"</span> <span class="p">),</span> <span class="s">"Continue"</span><span class="p">,</span> <span class="n">i18n</span><span class="p">(</span> <span class="s">"Continue the search from begining"</span> <span class="p">)</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why is "Continue from beginning" a better answer than "Yes" to the question "Continue from beginning?"</p></pre>
</div>
</div>
<br />
<p>- Albert Astals Cid</p>
<br />
<p>On març 20th, 2015, 5:46 p.m. UTC, sahil sehgal wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By sahil sehgal.</div>
<p style="color: grey;"><i>Updated mar. 20, 2015, 5:46 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=309739">309739</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Earlier the KmessageBox dialog box contained yes, no or continue buttons without any description. But now there is description like "Continue searching" etc in the boxes.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Executed successfully on the dialog boxes.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part.cpp <span style="color: grey">(36438af)</span></li>
<li>ui/searchlineedit.cpp <span style="color: grey">(2add7fa)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123085/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>