[Okular-devel] Review Request 124381: Make KF5 based okular coinstallable with KDE4 version

[Alex Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124381/
-----------------------------------------------------------

Review request for Okular and Albert Astals Cid.


Repository: okular


Description
-------

---

Install Okular5Config.cmake instead of OkularConfig.cmake

Otherwise Qt4 projects that have a find_package(Okular) can break
because CMake then selects moc from Qt5 which won't work

---

Make the KF5 okular library coinstallable with the KDE4 version

The KF5 based library has been renamed to libOkular5Core.so so that
both can coexist in /usr/lib(64)

---

Set the CMake target name from Okular::okularcore to Okular::Core


Diffs
-----

  CMakeLists.txt 3b882f31a853887c60cb247342a34b78ca0a20a1 
  OkularConfig.cmake.in 2b610fe156d8b52adba6075a2852e1507a3d73a2 

Diff: https://git.reviewboard.kde.org/r/124381/diff/


Testing
-------

Patched Kile to use find_package(Okular5), everything seems to work


Thanks,

Alex Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150718/f897c064/attachment.html>