[Okular-devel] Review Request 123905: Solution to Bug 271986 - A "Go to Bookmark..." action similar to "Go to Page..."

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123905/#review82592
-----------------------------------------------------------


Looks good but needs improvements:
 - Double clicking on the list item should activate it
 - Ok should be disabled if there's no selected item, otherwise i open the dialog, click ok, and nothing happens

also you need to increase the version on the rc file you modified otherwise the menu won't show for some people like me that customized their menus/shortcuts/stuff

- Albert Astals Cid


On mai. 25, 2015, 9:38 p.m., Nikola Nikolic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123905/
> -----------------------------------------------------------
> 
> (Updated mai. 25, 2015, 9:38 p.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 271986
>     http://bugs.kde.org/show_bug.cgi?id=271986
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Added Go->Go to Bookmark... menu item that opens Go to Bookmark window.
> Go to Bookmark window allow choosing bookmark from list, with optional use of filter.
> 
> 
> Diffs
> -----
> 
>   part.h 9eebdb2 
>   part.cpp d461ebe 
>   part.rc 60f86e5 
> 
> Diff: https://git.reviewboard.kde.org/r/123905/diff/
> 
> 
> Testing
> -------
> 
> Basic UI testing.
> 
> 
> Thanks,
> 
> Nikola Nikolic
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150716/f52fb7af/attachment-0001.html>