[Okular-devel] Review Request 126378: remove kactivities on windows

[Patrick Spendrin]

> On Dez. 16, 2015, 4:45 nachm., Alex Richardson wrote:
> > shell/shell.cpp, line 48
> > <https://git.reviewboard.kde.org/r/126378/diff/1/?file=423785#file423785line48>
> >
> >     `#if HAVE_KACTIVITIES` would be nicer and then KActivities could just be turned into an optional dependency which wouldn't be found on Windows?
> >     
> >     I prefer having ifdefs based on available features rather than hardcoded on the OS
> 
> Luigi Toscano wrote:
>     I think some commits ago (can't check now) kactivities was made mandatory, so there is something wrong that can happen reintroducing this check. Maybe. Not sure about the status on Windows, but please please ping Ivan as kactivities maintainer.

Well, there would be also the possibility to make kactivities mandatory on Linux, and optional on Windows/Mac.
I'll try to get a comment from ivan first...


- Patrick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126378/#review89610
-----------------------------------------------------------


On Dez. 16, 2015, 1:16 vorm., Patrick Spendrin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126378/
> -----------------------------------------------------------
> 
> (Updated Dez. 16, 2015, 1:16 vorm.)
> 
> 
> Review request for kdewin and Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> KActivities is not used on Windows, so a hard dependency on it
> only brings unneeded code.
> This patch removes it completely under Windows.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 72ff3e8754a9005dd09cf49e83d67b0a4f9258db 
>   shell/CMakeLists.txt 7a6af745464fe7bb1d6702cc02787e7e6d4c101e 
>   shell/shell.cpp e69ecbb5e1bde36dbd00e5ff05cdad4e3d2a5f8d 
> 
> Diff: https://git.reviewboard.kde.org/r/126378/diff/
> 
> 
> Testing
> -------
> 
> Windows.
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20151216/0a6e8ed0/attachment.html>