[Okular-devel] Review Request 126379: Windows string fixes

Patrick Spendrin ps_ml at gmx.de
Wed Dec 16 01:20:34 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126379/
-----------------------------------------------------------

Review request for kdewin and Okular.


Repository: okular


Description
-------

This patch changes multiline QStringLiterals to QString::fromLatin1
as QStringLiterals doesn't understand multiline strings on windows.
Also, strncasecmp is replaced by the portable qstricmp function provided
by QByteArray header.


Diffs
-----

  generators/dvi/dviRenderer_prescan.cpp 783c7273c6f7d1be03f5e970dc23e0a24a31197f 
  generators/dvi/psgs.cpp b1eedc42864abf5a868a5bc6eebf258b1f7cf168 
  generators/dvi/special.cpp 6a9fe69b2d44cfed95284b4d37f767c00c73721c 
  generators/epub/converter.cpp 16a6b5beabe1803ea4cdacc4d571edca7ff9ec23 
  ui/latexrenderer.cpp 8e42a9f88a8aa4ff73b544bf41642d59ca86474a 
  ui/pageview.cpp 13727e4647781cd9222956cae2c9e3fbc1a42324 

Diff: https://git.reviewboard.kde.org/r/126379/diff/


Testing
-------

Windows.


Thanks,

Patrick Spendrin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20151216/8cf9fbfa/attachment.html>


More information about the Okular-devel mailing list