[Okular-devel] Review Request 125792: Fix linking with okularpart.dll when using MSVC.

[Christian Ehrlicher]

> On Dez. 12, 2015, 11:25 nachm., Albert Astals Cid wrote:
> > Has the bug been reported to the cmake people?

This is no bug, this is the expected behaviour:
MODULE libraries are plugins that are not linked into other targets but may be loaded dynamically at runtime using dlopen-like functionality.
(from https://cmake.org/cmake/help/v3.0/command/add_library.html )


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125792/#review89403
-----------------------------------------------------------


On Dez. 10, 2015, 12:15 nachm., Gleb Popov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125792/
> -----------------------------------------------------------
> 
> (Updated Dez. 10, 2015, 12:15 nachm.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> To link with DLL using Visual Studio linker, it should be fed with .lib file corresponding to .dll being linked. For libraries created with SHARED keyword, CMake figures this out and passes correct file. But for okularpart target, the DLL itself is passed, which leads to error during linking.
> 
> This seems to be a bug in CMake and this patch works it around.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4aea44d 
> 
> Diff: https://git.reviewboard.kde.org/r/125792/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20151213/e76e7624/attachment.html>