[Okular-devel] Review Request 125792: Fix linking with okularpart.dll when using MSVC.

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125792/#review89403
-----------------------------------------------------------


Has the bug been reported to the cmake people?

- Albert Astals Cid


On des. 10, 2015, 12:15 p.m., Gleb Popov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125792/
> -----------------------------------------------------------
> 
> (Updated des. 10, 2015, 12:15 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> To link with DLL using Visual Studio linker, it should be fed with .lib file corresponding to .dll being linked. For libraries created with SHARED keyword, CMake figures this out and passes correct file. But for okularpart target, the DLL itself is passed, which leads to error during linking.
> 
> This seems to be a bug in CMake and this patch works it around.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4aea44d 
> 
> Diff: https://git.reviewboard.kde.org/r/125792/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20151212/1ecbb569/attachment.html>