[Okular-devel] Review Request 125791: Fix compilation of fax and comicbook generators with MSVC 2015.

[Gleb Popov]

> On Dec. 10, 2015, 10:55 a.m., Patrick Spendrin wrote:
> > generators/fax/faxexpand.h, line 25
> > <https://git.reviewboard.kde.org/r/125791/diff/1/?file=412711#file412711line25>
> >
> >     This should read #ifndef Q_OS_WIN
> >     but I guess this include can be removed for everybody?

Can't tell for *nixes, i don't have machine to test.


- Gleb


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125791/#review89294
-----------------------------------------------------------


On Dec. 10, 2015, 3:16 p.m., Gleb Popov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125791/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2015, 3:16 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Fix compilation of fax and comicbook generators with MSVC 2015.
> 
> 
> Diffs
> -----
> 
>   generators/comicbook/CMakeLists.txt deed292 
>   generators/fax/faxexpand.h f062974 
> 
> Diff: https://git.reviewboard.kde.org/r/125791/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20151210/5f683704/attachment.html>