[Okular-devel] Review Request 125792: Fix linking with okularpart.dll when using MSVC.

[Patrick Spendrin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125792/#review89296
-----------------------------------------------------------



CMakeLists.txt (line 316)
<https://git.reviewboard.kde.org/r/125792/#comment61064>

    I'd prefer it, if we would simply change MODULE to SHARED for everybody. This would make it clear that this is no simple plugin.


- Patrick Spendrin


On Okt. 25, 2015, 2:37 nachm., Gleb Popov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125792/
> -----------------------------------------------------------
> 
> (Updated Okt. 25, 2015, 2:37 nachm.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> To link with DLL using Visual Studio linker, it should be fed with .lib file corresponding to .dll being linked. For libraries created with SHARED keyword, CMake figures this out and passes correct file. But for okularpart target, the DLL itself is passed, which leads to error during linking.
> 
> This seems to be a bug in CMake and this patch works it around.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4aea44db6940d4a34c24d30d54c3980d2170e89f 
> 
> Diff: https://git.reviewboard.kde.org/r/125792/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20151210/bab28f06/attachment.html>