[Okular-devel] Review Request 124842: Fix picking of different view modes

[Jan Kundrát]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124842/
-----------------------------------------------------------

(Updated Aug. 25, 2015, 9:53 p.m.)


Status
------

This change has been marked as submitted.


Review request for Okular, Albert Astals Cid and Vishesh Handa.


Changes
-------

Submitted with commit cf513f3dd61ceb01069bf8f0614ecb5401452a71 by Albert Astals Cid on behalf of Jan Kundrát to branch frameworks.


Repository: okular


Description
-------

This was broken since commit 077689c4 when this got ported away from
KAction. The code attempted to add a parent QMenu to the QAction
instances nested below that parent. I'm quite surprised that it didn't
crash, but checkable actions do not go well with actions that have
nested menus, apparently.

I haven't checked the rest of the code for similar mistakes, but I don't
see any other case of this bug in Okular's menus when reading PDFs.


Diffs
-----

  ui/pageview.cpp 452869169b4b4b2702d6a43564cd54b2b6e2828c 

Diff: https://git.reviewboard.kde.org/r/124842/diff/


Testing
-------


Thanks,

Jan Kundrát

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150825/d1faf0b3/attachment-0001.html>