[Okular-devel] Review Request 124842: Fix picking of different view modes

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124842/#review84373
-----------------------------------------------------------

Ship it!


Ship It!

- Albert Astals Cid


On ago. 20, 2015, 6:23 p.m., Jan Kundrát wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124842/
> -----------------------------------------------------------
> 
> (Updated ago. 20, 2015, 6:23 p.m.)
> 
> 
> Review request for Okular, Albert Astals Cid and Vishesh Handa.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> This was broken since commit 077689c4 when this got ported away from
> KAction. The code attempted to add a parent QMenu to the QAction
> instances nested below that parent. I'm quite surprised that it didn't
> crash, but checkable actions do not go well with actions that have
> nested menus, apparently.
> 
> I haven't checked the rest of the code for similar mistakes, but I don't
> see any other case of this bug in Okular's menus when reading PDFs.
> 
> 
> Diffs
> -----
> 
>   ui/pageview.cpp 452869169b4b4b2702d6a43564cd54b2b6e2828c 
> 
> Diff: https://git.reviewboard.kde.org/r/124842/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Kundrát
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150825/57584c65/attachment.html>