[Okular-devel] Review Request 123314: Use generated version and CMake config files
Andreas Cord-Landwehr
cordlandwehr at kde.org
Fri Apr 10 16:14:44 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123314/
-----------------------------------------------------------
(Updated April 10, 2015, 4:14 nachm.)
Review request for Okular, Albert Astals Cid, Alex Richardson, and Eugene Shalygin.
Changes
-------
Both issues are fixed. Also fixed another issue just spotted on a clean install test.
Repository: okular
Description
-------
Replace both the package version file by a generated file, as well as OkularConfig.cmake package configuration file.
Note that with this change the compatibility CMake variable OKULAR_FOUND is not set anymore, use Okular_FOUND instead.
This patch (should) fix the regression on eg. Gentoo systems introduced by RR #123176
Diffs (updated)
-----
CMakeLists.txt 56c9976
OkularConfig.cmake 171b845
OkularConfig.cmake.in PRE-CREATION
core/version.h 855df95
Diff: https://git.reviewboard.kde.org/r/123314/diff/
Testing
-------
Manual testing on a Debian system
@Eugene: does it fix the regression for you?
Thanks,
Andreas Cord-Landwehr
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150410/1e12ddf5/attachment.html>
More information about the Okular-devel
mailing list