[Okular-devel] Review Request 123314: Use generated version and CMake config files

[Alex Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123314/#review78767
-----------------------------------------------------------


Looks good to me once these two issues are fixed.


CMakeLists.txt (line 186)
<https://git.reviewboard.kde.org/r/123314/#comment53899>

    This is being installed twice now. Add the EXPORT OkularTargets to the install() a few lines further down.



CMakeLists.txt (line 318)
<https://git.reviewboard.kde.org/r/123314/#comment53900>

    Why is this needed? It's not in the original code and unrelated to generating the OkularConfig.cmake file.


- Alex Richardson


On April 9, 2015, 9:18 p.m., Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123314/
> -----------------------------------------------------------
> 
> (Updated April 9, 2015, 9:18 p.m.)
> 
> 
> Review request for Okular, Albert Astals Cid, Alex Richardson, and Eugene Shalygin.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Replace both the package version file by a generated file, as well as OkularConfig.cmake package configuration file.
> Note that with this change the compatibility CMake variable OKULAR_FOUND is not set anymore, use Okular_FOUND instead.
> 
> This patch (should) fix the regression on eg. Gentoo systems introduced by RR #123176
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 56c9976 
>   OkularConfig.cmake 171b845 
>   OkularConfig.cmake.in PRE-CREATION 
>   core/version.h 855df95 
> 
> Diff: https://git.reviewboard.kde.org/r/123314/diff/
> 
> 
> Testing
> -------
> 
> Manual testing on a Debian system
> 
> @Eugene: does it fix the regression for you?
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20150410/d3b230f7/attachment.html>