[Okular-devel] Review Request 120378: Port from KInputDialog to QInputDialog
Albert Astals Cid
aacid at kde.org
Sat Sep 27 13:14:28 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120378/#review67523
-----------------------------------------------------------
Ship it!
It's ok, if the old ones didn't have parent i guess it's ok if these ones don't ahve it either, the behaviour will be as good/bad.
- Albert Astals Cid
On set. 26, 2014, 1:47 p.m., Arnold Dumas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120378/
> -----------------------------------------------------------
>
> (Updated set. 26, 2014, 1:47 p.m.)
>
>
> Review request for Okular, Albert Astals Cid and Frederik Gladhorn.
>
>
> Repository: okular
>
>
> Description
> -------
>
> Port from KInputDialog to QInputDialog.
>
>
> Diffs
> -----
>
> part.cpp a65c7f6
> ui/pageview.cpp f1c5589
> ui/pageviewannotator.cpp d155f8b
>
> Diff: https://git.reviewboard.kde.org/r/120378/diff/
>
>
> Testing
> -------
>
> It builds.
>
>
> Thanks,
>
> Arnold Dumas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140927/6f1f7ae4/attachment.html>
More information about the Okular-devel
mailing list