[Okular-devel] Review Request 120378: Port from KInputDialog to QInputDialog

[Arnold Dumas]

> On sep. 26, 2014, 10:51 après-midi, Albert Astals Cid wrote:
> > ui/pageview.cpp, line 4747
> > <https://git.reviewboard.kde.org/r/120378/diff/1/?file=315494#file315494line4747>
> >
> >     why no widget here?

It can be parented to this.


> On sep. 26, 2014, 10:51 après-midi, Albert Astals Cid wrote:
> > ui/pageviewannotator.cpp, line 167
> > <https://git.reviewboard.kde.org/r/120378/diff/1/?file=315495#file315495line167>
> >
> >     why no widget here?

There is no suitable widget to consider as parent.


- Arnold


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120378/#review67506
-----------------------------------------------------------


On sep. 26, 2014, 1:47 après-midi, Arnold Dumas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120378/
> -----------------------------------------------------------
> 
> (Updated sep. 26, 2014, 1:47 après-midi)
> 
> 
> Review request for Okular, Albert Astals Cid and Frederik Gladhorn.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Port from KInputDialog to QInputDialog.
> 
> 
> Diffs
> -----
> 
>   part.cpp a65c7f6 
>   ui/pageview.cpp f1c5589 
>   ui/pageviewannotator.cpp d155f8b 
> 
> Diff: https://git.reviewboard.kde.org/r/120378/diff/
> 
> 
> Testing
> -------
> 
> It builds.
> 
> 
> Thanks,
> 
> Arnold Dumas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140927/c4329322/attachment-0001.html>