[Okular-devel] Review Request 118236: Save the okular printer settings in a config file, to make them persistent across sessions

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118236/#review58398
-----------------------------------------------------------


I'm undecided about this, i know it is something people want, but it looks extremely fragile the way stuff is saved/restored.

Do you think you could have a look and see if Qt5 offers this feature? And maybe if not implement it there? Qt5 is muuuuuuuuuch more open thatn Qt4 so implementing small features like this should not be that hard. I'll also add John Layt to the review, he's been working on Qt5 Printing stuff and maybe has time to comment a bit.

- Albert Astals Cid


On May 21, 2014, 9:42 a.m., Oliver Sander wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118236/
> -----------------------------------------------------------
> 
> (Updated May 21, 2014, 9:42 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Save the okular printer settings in a config file, to make them persistent across sessions.
> 
> This is the patch submitted by user 'Hulahup' in Comment 4 of https://bugs.kde.org/show_bug.cgi?id=308367
> 
> I extended it to also store the duplex mode of the printer.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b869aec 
>   conf/printer.h PRE-CREATION 
>   conf/printer.cpp PRE-CREATION 
>   conf/printer.kcfg PRE-CREATION 
>   conf/settings_printer.kcfgc PRE-CREATION 
>   part.cpp d9f1682 
> 
> Diff: https://git.reviewboard.kde.org/r/118236/diff/
> 
> 
> Testing
> -------
> 
> Duplex mode appears to be correctly stored.  Yay!
> 
> 
> Thanks,
> 
> Oliver Sander
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140524/c3f76c5c/attachment.html>