[Okular-devel] Review Request 117267: make width of the rectangle for inline note in annotations configurable

[Fabio D'Urso]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117267/#review57567
-----------------------------------------------------------


Hi Alin! Sorry for the very late reply...

We don't need to show this new property for *all* annotation types. Currently, you're showing it for eg stamps and line annotations too (duplicating the size property we already have).
I'd add this new property in TextAnnotationWidget::createStyleWidget (under the InPlace branch) rather than AnnotationWidget::createAppearanceWidget, which is shared by all annotation types.

Another issue I've noticed is that this property is not saved if you create a custom annotation tool (Configure Okular... -> Annotations).

Also, if we want to be picky :D, ui/pagepainter.cpp needs to be patched too, to make this property work on non-PDF documents too. This is probably just a matter of setting the pen width around line 709.

Sorry again for the delay :)


- Fabio D'Urso


On May 2, 2014, 3:28 p.m., Alin M Elena wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117267/
> -----------------------------------------------------------
> 
> (Updated May 2, 2014, 3:28 p.m.)
> 
> 
> Review request for Okular and Fabio D'Urso.
> 
> 
> Bugs: 332887
>     http://bugs.kde.org/show_bug.cgi?id=332887
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> make width of the rectangle for inline note in annotations configurable
> promised it to fabio few months back... never got the time to it till now
> 
> 
> Diffs
> -----
> 
>   ui/annotationwidgets.h 6e7a218 
>   ui/annotationwidgets.cpp 450e50b 
> 
> Diff: https://git.reviewboard.kde.org/r/117267/diff/
> 
> 
> Testing
> -------
> 
> saved a document with various widths for border from 0 to more... opened it in windows acroread and worked.
> 
> 
> Thanks,
> 
> Alin M Elena
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140508/545ca884/attachment.html>