<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117267/">https://git.reviewboard.kde.org/r/117267/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi Alin! Sorry for the very late reply...
We don't need to show this new property for *all* annotation types. Currently, you're showing it for eg stamps and line annotations too (duplicating the size property we already have).
I'd add this new property in TextAnnotationWidget::createStyleWidget (under the InPlace branch) rather than AnnotationWidget::createAppearanceWidget, which is shared by all annotation types.
Another issue I've noticed is that this property is not saved if you create a custom annotation tool (Configure Okular... -> Annotations).
Also, if we want to be picky :D, ui/pagepainter.cpp needs to be patched too, to make this property work on non-PDF documents too. This is probably just a matter of setting the pen width around line 709.
Sorry again for the delay :)
</pre>
<br />
<p>- Fabio D'Urso</p>
<br />
<p>On May 2nd, 2014, 3:28 p.m. UTC, Alin M Elena wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular and Fabio D'Urso.</div>
<div>By Alin M Elena.</div>
<p style="color: grey;"><i>Updated May 2, 2014, 3:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=332887">332887</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">make width of the rectangle for inline note in annotations configurable
promised it to fabio few months back... never got the time to it till now</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">saved a document with various widths for border from 0 to more... opened it in windows acroread and worked.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ui/annotationwidgets.h <span style="color: grey">(6e7a218)</span></li>
<li>ui/annotationwidgets.cpp <span style="color: grey">(450e50b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117267/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>