[Okular-devel] Review Request 118862: Fix two icons in the Tools menu and add an icon for FB backend

[Yuri Chornoivan]

> On Липень 10, 2014, 9:34 після полудня, Albert Astals Cid wrote:
> > Where do the fictionbook icons come from? Is something you did?
> > 
> > Meanwhile i've commited the other changes for icons
> 
> Yuri Chornoivan wrote:
>     Taken from this topic on the forum:
>     
>     http://www.the-ebook.org/forum/viewtopic.php?t=3391&sid=c7d8b99d1b6efae43a11f1c6e9467df3
>     
>     I have made an SVG version of 32x32 icon (attached, can do for other resolutions as well).
> 
> Albert Astals Cid wrote:
>     What's the copyright/trademark stuff of this? Are we sure we can use it freely?

An email sent to the original author to clear up the licensing issues. As it is some what different problem, this RR can be closed now as partially submitted. The RR for FB2 icons will be resubmitted as soon as the licensing problems are solved.


- Yuri


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118862/#review62099
-----------------------------------------------------------


On Липень 11, 2014, 7:46 до полудня, Yuri Chornoivan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118862/
> -----------------------------------------------------------
> 
> (Updated Липень 11, 2014, 7:46 до полудня)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 336530
>     http://bugs.kde.org/show_bug.cgi?id=336530
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> Use the available icons from Oxygen for the Tools actions. Add "official" FictionBook icons for the backends configuration window.
> 
> 
> Diffs
> -----
> 
>   generators/fictionbook/CMakeLists.txt 4fe3877 
>   generators/fictionbook/generator_fb.cpp 466fb72 
>   ui/pageview.cpp 9073139 
> 
> Diff: https://git.reviewboard.kde.org/r/118862/diff/
> 
> 
> Testing
> -------
> 
> Works as expected for git/master.
> 
> 
> File Attachments
> ----------------
> 
> FB2 16x16 icon
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/06/21/10e48f57-ec32-49a8-ae3f-52c757695aa2__hi16-app-okular-fb2.png
> FB2 32x32 icon
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/06/21/53218660-0fd5-4231-8440-e89d0f577cf5__hi32-app-okular-fb2.png
> FB2 48x48 icon
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/06/21/c648c801-f3b9-4caf-b3a1-fbf03050f13e__hi48-app-okular-fb2.png
> SVG version for 32x32 icon
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/07/11/9e5e2b36-b020-46bd-aafb-a53b211b9df0__hi32-app-okular-fb2.svg
> 
> 
> Thanks,
> 
> Yuri Chornoivan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140714/23f0e07c/attachment.html>